Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] migrate arbitrum testnet to sepolia #465

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

avichalp
Copy link
Contributor

@avichalp avichalp commented Nov 13, 2023

Summary

Migrates Arbitrum testnet from goerli to sepolia. Goerli is already deprecated. Alchemy will stop supporting it from next week.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

README.md Outdated
@@ -30,7 +30,7 @@ This is the Tableland Tables EVM contracts and client components.
| filecoin | 314 | 0x59EF8Bf2d6c102B4c42AEf9189e1a9F0ABfD652d |
| sepolia | 11155111 | 0xc50C62498448ACc8dBdE43DA77f8D5D2E2c7597D |
| optimism-goerli | 420 | 0xC72E8a7Be04f2469f8C2dB3F1BdF69A7D516aBbA |
| arbitrum-goerli | 421613 | 0x033f69e8d119205089Ab15D340F5b797732f646b |
| arbitrum-sepolia | 421614 | 0xTODO |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add the deployed address here

0x033f69e8d119205089Ab15D340F5b797732f646b;
// TablelandTables address on Arbitrum Sepolia.
address internal constant ARBITRUM_SEPOLIA =
0x000000000000000000000000000000000000dEaD;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add the deployed address here

@dtbuchholz
Copy link
Contributor

@avichalp nre in case you're already planning on doing the following. I remember we temporarily added back Ethereum Goerli to the validator for the sake of a dev's need to use it during a hackathon. We can drop that from the config, too, once we make the changes you've noted here. Reference: https://github.com/tablelandnetwork/go-tableland/blob/main/docker/deployed/testnet/api/config.json

Signed-off-by: Sander Pick <[email protected]>
@sanderpick sanderpick marked this pull request as ready for review November 13, 2023 21:00
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with the new contract info.

@avichalp avichalp merged commit e0a6802 into main Nov 14, 2023
2 checks passed
@avichalp avichalp deleted the avichalp/arbitrum-migration branch November 14, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants